Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: modify the ENS validation to work in safari or older browsers #687

Merged
merged 1 commit into from
May 23, 2022
Merged

fix: modify the ENS validation to work in safari or older browsers #687

merged 1 commit into from
May 23, 2022

Conversation

vojtechsimetka
Copy link
Contributor

@vojtechsimetka vojtechsimetka commented May 23, 2022 •
edited by AuHau
Loading

Closes #686

@vojtechsimetka vojtechsimetka requested a review from AuHau as a code owner May 23, 2022 12:26
@vojtechsimetka vojtechsimetka force-pushed the fix/ens-regexp-that-works-in-safari branch from d4bb8b1 to 90dcfc2 Compare May 23, 2022 12:29
AuHau
AuHau approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@AuHau AuHau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot 🙏

@AuHau AuHau merged commit 2e172fb into master May 23, 2022
@AuHau AuHau deleted the fix/ens-regexp-that-works-in-safari branch May 23, 2022 12:38
@bee-worker bee-worker mentioned this pull request May 23, 2022
Merged
@bee-worker
Copy link
Collaborator

Release v4.1.0 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AuHau AuHau AuHau approved these changes

Assignees
No one assigned
Labels
type:pull-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid regular expression error in Safari
3 participants
@vojtechsimetka @bee-worker @AuHau