Bug: wrong createTag implementation in modules/tag.ts

[Aviksaikat]

Overview

According to the docs the createTag is not taking account of the address parameter. As the parameter is not required but there should be an option to pass this.

file: modules/tag.ts

Solution

The correct implementation should be like this

export async function createTag(requestOptions: BeeRequestOptions, address: EthAddress | string): Promise<Tag> {
  const response = await http<Tag>(requestOptions, {
    method: 'post',
    url: endpoint,
    responseType: 'json',
   params: address
  })

  return response.data
}

[Cafe137]

Hello @Aviksaikat!

Thank you for identifying the issue and providing the code sample.

Would you be up to creating a PR so your contribution is properly recorded?

[Aviksaikat]

sure thing