Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current master (1d5c07c4) panics when built with golang 1.17.1 #2516

Closed
ldeffenb opened this issue Sep 16, 2021 · 2 comments
Closed

Current master (1d5c07c4) panics when built with golang 1.17.1 #2516

ldeffenb opened this issue Sep 16, 2021 · 2 comments
Labels
issue needs-triaging new issues that need triaging

Comments

@ldeffenb
Copy link
Collaborator

Summary

Cloned a fresh copy of the current master (1d5c07c) and built it with go version go1.17.1 linux/amd64 successfully. But the resulting executable panics when simply asking for the version.

ldeffenb@osm:~$ mkdir master2
ldeffenb@osm:~$ cd master2
ldeffenb@osm:~/master2$ git clone https://github.com/ethersphere/bee.git
Cloning into 'bee'...
remote: Enumerating objects: 20253, done.
remote: Counting objects: 100% (1604/1604), done.
remote: Compressing objects: 100% (837/837), done.
remote: Total 20253 (delta 975), reused 1205 (delta 729), pack-reused 18649
Receiving objects: 100% (20253/20253), 6.34 MiB | 6.34 MiB/s, done.
Resolving deltas: 100% (13455/13455), done.
ldeffenb@osm:~/master2$ cd bee
ldeffenb@osm:~/master2/bee$ make binary
mkdir dist
go version
go version go1.17.1 linux/amd64
go build -trimpath -ldflags "-s -w -X github.com/ethersphere/bee.commitHash=""1d5c07c4"" -X github.com/ethersphere/bee.commitTime=""1631792277""" -o dist/bee ./cmd/bee
ldeffenb@osm:~/master2/bee$ dist/bee version
panic: qtls.ClientHelloInfo doesn't match

goroutine 1 [running]:
github.com/marten-seemann/qtls-go1-15.init.0()
        github.com/marten-seemann/qtls-go1-15@v0.1.1/unsafe.go:20 +0x132

Steps to reproduce

Clone a new copy, build it with golang 1.17.1 and try to run dist/bee version

Expected behavior

If it built, I expected it to run.

Actual behavior

Panics when simply asking for version.

@ldeffenb ldeffenb added the needs-triaging new issues that need triaging label Sep 16, 2021
@bee-runner bee-runner bot added the issue label Sep 16, 2021
@ldeffenb
Copy link
Collaborator Author

ldeffenb commented Sep 16, 2021

Note: I rolled back my golang to go version go1.16.1 linux/amd64 and it builds and runs successfully. As I mentioned at the bottom of #2515, it would be good if the makefile could validate the required golang version to avoid very confusing error messages. Especially when 1.15 and 1.17 both fail in different ways, but 1.16 works!

@acud
Copy link
Member

acud commented Sep 16, 2021

there's an open PR to upgrade to go 1.17. it doesn't work out of the box. it will be handled soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue needs-triaging new issues that need triaging
Projects
None yet
Development

No branches or pull requests

2 participants