Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Underflow protection in reserve size updates #3231

Closed
metacertain opened this issue Aug 29, 2022 · 0 comments
Closed

Underflow protection in reserve size updates #3231

metacertain opened this issue Aug 29, 2022 · 0 comments
Labels
bug Something isn't working issue

Comments

@metacertain
Copy link
Member

Summary

In pkg/localstore/gc.go

			// protect uint64 undeflow
			return nil

occures twice, each place seems like we don't set the reservesize to even 0 if theres a larger decrease than the current reserveSize
@metacertain metacertain added bug Something isn't working needs-triaging new issues that need triaging labels Aug 29, 2022
@bee-runner bee-runner bot added the issue label Aug 29, 2022
@agazso agazso removed the needs-triaging new issues that need triaging label Sep 12, 2022
@istae istae closed this as completed Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@agazso @istae @metacertain