Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evict just enough chunks of a batch to fall below the reserve capacity #4538

Closed
istae opened this issue Jan 12, 2024 · 0 comments · Fixed by #4549
Closed

evict just enough chunks of a batch to fall below the reserve capacity #4538

istae opened this issue Jan 12, 2024 · 0 comments · Fixed by #4549
Assignees
Labels

Comments

@istae
Copy link
Member

istae commented Jan 12, 2024

To minimize chunks loss, we should only evict enough chunks fall below the capacity.
This can be done by passing a "max evict counter" calculated in the unreserve function and passed to the evict batch function.

The other required change is that the collected items should be sorted by binID first so that the older chunks are evicted first.

Also, we can temporarily disable caching of evicted chunks until a performant and stable solution is found: see #4530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment