Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

Move connection configuration functions from swarm to p2p #1040

Closed
nolash opened this issue Dec 3, 2018 · 1 comment
Closed

Move connection configuration functions from swarm to p2p #1040

nolash opened this issue Dec 3, 2018 · 1 comment
Labels
enhancement good first issue simulations
Milestone
2018 Christmas Ed...

Comments

@nolash
Copy link
Contributor

nolash commented Dec 3, 2018 •
edited
Loading

swarm/network/simulation/connect.go provides functions to connect networks in different configurations, but these are useful on p2p/simulations level and do not depend on anything precluding them from being there.

Comment from @janos:

Some of them rely on UpNodeIDs, PivotNodeID or RandomUpNode. This functions also should be ported on lower level, they are very simple, except the pivot one, it is a concept only in simulation package.
@zelig
Copy link
Member

zelig commented Dec 18, 2018

ethereum/go-ethereum#18323

@zelig zelig closed this as completed Dec 18, 2018
@zelig zelig added this to the 2018 Christmas Edition milestone Dec 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement good first issue simulations
Projects
None yet
Milestone
2018 Christmas Edition
Development

No branches or pull requests
2 participants
@zelig @nolash