Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

Unify variable types between SC and go code #1581

Open
vojtechsimetka opened this issue Jul 17, 2019 · 4 comments
Open

Unify variable types between SC and go code #1581

vojtechsimetka opened this issue Jul 17, 2019 · 4 comments

Comments

@vojtechsimetka
Copy link

vojtechsimetka commented Jul 17, 2019

Problem

Right now there is a mishmatch between the size of numbers (and potentially other types) between the go code and smart contracts. For example the cheque values are 256 bits integers on the SC side but only 64 bits on go code.

Task

Go through the go code and make it compliant with the smart contracts.

@mortelli
Copy link
Contributor

mortelli commented Jan 6, 2020

This issue was deemed too big to be completed in one go.

As a result, it's going to be implemented through multiple PRs.

The first one, which adds the Uint256 type, is PR #2063.

@acud acud removed the urgent label Jan 6, 2020
@mortelli
Copy link
Contributor

This issue was deemed too big to be completed in one go.

As a result, it's going to be implemented through multiple PRs.

The first one, which adds the Uint256 type, is PR #2063.

Part 1 merged.

@mortelli
Copy link
Contributor

mortelli commented Jan 27, 2020

Part 2 for implementing this issue has been submitted: PR #2082.

@Eknir
Copy link
Contributor

Eknir commented Feb 18, 2020

5-7 working days

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants