Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

On node startup, check the contract is already deployed #1599

Closed
holisticode opened this issue Jul 24, 2019 · 3 comments · Fixed by #1718
Closed

On node startup, check the contract is already deployed #1599

holisticode opened this issue Jul 24, 2019 · 3 comments · Fixed by #1718

Comments

@holisticode
Copy link
Contributor

Currently, when we start up the node, we deploy the contract every time.

We need to check when we start the node if the contract has already been deployed, and if it has, not deploy again.

@vojtechsimetka
Copy link

I would go even further. User should be able to provide the contract address through config/argument.

Arguably it should only be deployed when the first cheque is needed to be issues, but not sure.

@ralph-pichler
Copy link
Member

Arguably it should only be deployed when the first cheque is needed to be issues, but not sure.

That would break the way we currently exchange contract addresses. We expect both parties to already have the address at the moment of the handshake of the swap protocol.

@mortelli
Copy link
Contributor

mortelli commented Sep 6, 2019

for clarification purposes: could someone please document here (or there) the difference between this issue and #1548?

relevant PR: #1718

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants