Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

Pss outbox queue to handle failed message sends #339

Closed
nolash opened this issue Mar 19, 2018 · 1 comment
Closed

Pss outbox queue to handle failed message sends #339

nolash opened this issue Mar 19, 2018 · 1 comment
Assignees
@nolash
Labels
enhancement pss
Milestone
master merge

Comments

@nolash
Copy link
Contributor

nolash commented Mar 19, 2018

Currently, if the Send method on the protocols.Peer in the Pss.forward kademlia iteration fails, the error is never detected. This is because of the constraint that Send must be called asynchronously. Furthermore, if the node momentarily has no other peers than the peer it received message from, forwarding will never happen.

Sending and forwarding should instead put message in a queue, which is shifted by a never ending loop in the Pss service, and which re-adds messages if forwarding fails.
@nolash nolash self-assigned this Mar 19, 2018
@nolash nolash mentioned this issue Mar 19, 2018
Closed
@nolash nolash mentioned this issue Mar 29, 2018
Merged
@nolash nolash added this to the master merge milestone Mar 30, 2018
@nolash
Copy link
Contributor Author

nolash commented Apr 3, 2018

resolved with #354

@nolash nolash closed this as completed Apr 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nolash nolash

Labels
enhancement pss
Projects
None yet
Milestone
master merge
Development

No branches or pull requests
1 participant
@nolash