Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

fix pss forwarding #995

Closed
zelig opened this issue Nov 14, 2018 · 5 comments
Closed

fix pss forwarding #995

zelig opened this issue Nov 14, 2018 · 5 comments

Comments

@zelig
Copy link
Member

zelig commented Nov 14, 2018

Previously, redundancy forwards would be made if the previous peer was among nearest neighbors or within the "dark radius" (proximity order within the bounds of the part of the address not disclosed). However, it would not check if the next peer actually was within these bounds.

@nolash
Copy link
Contributor

nolash commented Nov 16, 2018

pending merge of #965

@nolash
Copy link
Contributor

nolash commented Nov 20, 2018

PR in progress: #1008

@acud
Copy link
Member

acud commented Dec 5, 2018

@zelig @nolash @gluk256 please give a description of what was exactly the bug, and what the PRs involved are doing.

@gluk256's PR referenced this issue but it is not clear what was the original problem was in the first place, for those not involved.

@nolash
Copy link
Contributor

nolash commented Dec 5, 2018

@justelad copied the original problem description from #1008 to the issue.

The PR should describe themselves so I won't put that here.

@zelig
Copy link
Member Author

zelig commented Dec 24, 2018

merged as. ethereum/go-ethereum#18353

@zelig zelig closed this as completed Dec 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.