Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beacon_metrics_gazer & light_beaconchain_launcher don't account for the validator_count #222

Closed
h4ck3rk3y opened this issue Sep 22, 2023 · 0 comments · Fixed by #223
Closed

Comments

@h4ck3rk3y
Copy link
Collaborator

this leads to misleading data being reported on the light beacon chain explorer

sample input

{
	"participants": [
		{
			"el_client_type": "nethermind",
			"el_client_image": "nethermind/nethermind:latest",
			"el_client_log_level": "",
			"cl_client_type": "lighthouse",
			"cl_client_log_level": "",
			"cl_client_image": "sigp/lighthouse",
			"el_extra_params": [
				"--Mining.ExtraData=\"Discovery Node\""
			],
            "validator_count": 0
		},
		{
			"el_client_type": "nethermind",
			"el_client_image": "nethermind/nethermind:latest",
			"el_client_log_level": "",
			"cl_client_type": "lighthouse",
			"cl_client_log_level": "",
			"cl_client_image": "sigp/lighthouse",
			"el_extra_params": [
				"--Network.MaxActivePeers=0",
				"--TxPool.Size=0",
				"--Mining.ExtraData=\"Proper Validator Node\""
			]
		}
	],
	"network_params": {
		"capella_fork_epoch": 1,
		"seconds_per_slot": 5
	}
}
image

validators should have been reported against cl-2 but they are incorrectly reported against cl-1 as the logic doesn't account for the validator_count change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant