feat: update Lodestar BN <> VC compatibility #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
changed the title
|
Regarding the issue with Nimbus BN, can be resolved by forcing Lodestar to sent requests as JSON This config works participants:
- el_type: geth
el_image: ethereum/client-go:stable
cl_type: lodestar
cl_image: chainsafe/lodestar:next
vc_type: nimbus
vc_image: statusim/nimbus-validator-client:amd64-latest
vc_extra_params:
- --doppelganger-detection=off
count: 2
- el_type: geth
el_image: ethereum/client-go:stable
cl_type: nimbus
cl_image: statusim/nimbus-eth2:amd64-latest
vc_type: lodestar
vc_image: chainsafe/lodestar:next
vc_extra_params:
- --http.requestWireFormat=json # <-- Lodestar VC will publish JSON-serialized blocks
count: 2The chain is finalizing and no missed proposals with 100% pariticipation.
|
|
The result from running the full config from PR description Block proposal assertion passed, haven't seen any missed proposals |
|
I can confirm latest lodestar BN is compatible with all VCs :) Testing latest nimbus BN, the compatibility actually got worse. I'm not really happy with supplying special flags for client compatibility. When looking at the snooper logs from Nimbus BN <> Nimbus/Lighthouse VC I can see that they're using the I think this should be resolved with nimbus instead of working around the issue with special flags :) |
Might be a combination of both as v2 adds broadcast validation, not sure where Nimbus does the signature check though. I tend to agree that client should be compatible by default. I reported this issue a while ago on Nimbus side, it was closed but it is not actually resolved. Maybe should re-open this or open a new issue. |
pk910
approved these changes
Jun 11, 2024
This was referenced Jun 11, 2024
h4ck3rk3y
pushed a commit
that referenced
this pull request
Jun 13, 2024
🤖 I have created a release *beep* *boop* --- ## [4.0.0](3.1.0...v4.0.0) (2024-06-13) ### ⚠ BREAKING CHANGES * migrate from kurtosis-tech to ethpandaops repository ([#663](#663)) ### Features * add names to run-sh ([#666](#666)) ([6b447b7](6b447b7)) * Adding arbitrary contract definition ([#646](#646)) ([cb58b65](cb58b65)) * migrate from kurtosis-tech to ethpandaops repository ([#663](#663)) ([d980fee](d980fee)) * update Lodestar BN <> VC compatibility ([#664](#664)) ([7f365da](7f365da)) ### Bug Fixes * permissions on autorelease ([#671](#671)) ([fcaa2c2](fcaa2c2)) * update release please ([#670](#670)) ([fa53672](fa53672)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lodestar works with all clients now on
unstablebranch(es).There is just one exception which is related to publishing blocks to Nimbus BN but that's an issue with all other VCs as well and seems to be only happening when running via kurtosis as confirmed here status-im/nimbus-eth2#6205 (comment). This issue can be solved though by forcing Lodestar to publish blocks as JSON, see #664 (comment).
The kurtosis config I was using