Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lodestar vc faster startup #721

Merged
merged 10 commits into from
Aug 9, 2024
Merged

fix: lodestar vc faster startup #721

merged 10 commits into from
Aug 9, 2024

Conversation

barnabasbusa
Copy link
Contributor

No description provided.

@barnabasbusa barnabasbusa enabled auto-merge (squash) July 16, 2024 10:22
@pk910
Copy link
Member

pk910 commented Jul 18, 2024 •
edited
Loading

Tested & works fine.
However, this uses a new flag --disableKeystoresThreadPool, which is not recognized by older images (including the latest stable release & pectra images) yet.
If the flag is not known, lodestar errors out with ✖ Unknown argument: disableKeystoresThreadPool, which prevents us from using these images and effectively breaks our current testing setup.
We should not merge this PR in until the flag is recognized by the latest stable release & all important feature branches (pectra, peerdas, verkle, ...)

@nflaig
Copy link
Contributor

nflaig commented Jul 19, 2024

we had to cut and patch release and also included --disableKeystoresThreadPool flag in there, so we are good on our next and latest release but electra and peerdas branch still needs to be updated with the change

@barnabasbusa
Copy link
Contributor Author

@nflaig any update on this? Does electra/peerdas branch expected to get this flag update anytime soon?

@nflaig
Copy link
Contributor

nflaig commented Jul 29, 2024

@nflaig any update on this? Does electra/peerdas branch expected to get this flag update anytime soon?

Some time this week, although unclear for peerdas branch, will keep you updated once those branches support the flag

@barnabasbusa
Copy link
Contributor Author

barnabasbusa commented Jul 29, 2024 •
edited
Loading

Currently waiting for:

to support this new flag before we can merge it

@barnabasbusa barnabasbusa enabled auto-merge (squash) August 9, 2024 12:22
@barnabasbusa barnabasbusa merged commit 225e3d8 into main Aug 9, 2024
13 checks passed
@barnabasbusa barnabasbusa deleted the barnabasbusa-patch-1 branch August 9, 2024 12:40
@EthPandaOpsBot EthPandaOpsBot mentioned this pull request Aug 9, 2024
Merged
barnabasbusa pushed a commit that referenced this pull request Aug 19, 2024
@EthPandaOpsBot
chore(main): release 4.2.0 (#709)
2e9e5a4 
🤖 I have created a release *beep* *boop*
---


##
[4.2.0](4.1.0...4.2.0)
(2024-08-19)


### Features

* add customizable configuraiton for prometheus retention
([#745](#745))
([6c02dfe](6c02dfe))
* add genesis_gaslimit param configuration
([#726](#726))
([a4ba9a6](a4ba9a6))
* Add Lighthouse PeerDAS Dashboard
([#736](#736))
([ffbfde2](ffbfde2))
* add peerdas-electra-support
([#740](#740))
([663e7e6](663e7e6))
* add profiling for prysm
([#722](#722))
([7dc6660](7dc6660))
* add sanity check
([#710](#710))
([b824cac](b824cac))
* enable dora pprof
([#743](#743))
([2b7be9a](2b7be9a))
* generate keys if not default key is used
([#707](#707))
([2d1cab5](2d1cab5))
* lodestar persists invalid ssz objects by default
([#730](#730))
([5a45991](5a45991))
* update egg config parameters
([#737](#737))
([78c2bc7](78c2bc7))


### Bug Fixes

* add debug ns to nethermind
([#732](#732))
([372bb52](372bb52))
* allow vc properties in participants_matrix.cl
([#715](#715))
([c8b9b19](c8b9b19))
* besu devnet schedule
([#734](#734))
([28b67cd](28b67cd))
* blobscan redis dependency
([#712](#712))
([0ed1c9c](0ed1c9c))
* change churn limit default for pectra tests
([#747](#747))
([8109054](8109054))
* correctly apply extra params if builder is enabled
([#725](#725))
([a94caf0](a94caf0))
* disable all assertoor tests by default
([#738](#738))
([2961f96](2961f96))
* lodestar vc faster startup
([#721](#721))
([225e3d8](225e3d8))
* readme eof
([#739](#739))
([7f94f6e](7f94f6e))
* remove custom peerdas images for dora & assertoor
([#741](#741))
([a19398d](a19398d))
* remove subscribe all subnet nimbus
([#719](#719))
([ef92f8f](ef92f8f))
* remove subscribe-all-subnets from default prysm config
([#717](#717))
([6348c0b](6348c0b))
* remove subscribe-all-subnets lighthouse/lodestar/teku
([#720](#720))
([cdb20e1](cdb20e1))
* update snapshots URL
([#731](#731))
([f9269ad](f9269ad))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nflaig nflaig nflaig left review comments

@MetaFomos MetaFomos MetaFomos approved these changes

@pk910 pk910 pk910 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@barnabasbusa @pk910 @nflaig @MetaFomos