fix: correctly apply extra params if builder is enabled #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! |
barnabasbusa
approved these changes
Jul 29, 2024
barnabasbusa
pushed a commit
that referenced
this pull request
Aug 19, 2024
🤖 I have created a release *beep* *boop* --- ## [4.2.0](4.1.0...4.2.0) (2024-08-19) ### Features * add customizable configuraiton for prometheus retention ([#745](#745)) ([6c02dfe](6c02dfe)) * add genesis_gaslimit param configuration ([#726](#726)) ([a4ba9a6](a4ba9a6)) * Add Lighthouse PeerDAS Dashboard ([#736](#736)) ([ffbfde2](ffbfde2)) * add peerdas-electra-support ([#740](#740)) ([663e7e6](663e7e6)) * add profiling for prysm ([#722](#722)) ([7dc6660](7dc6660)) * add sanity check ([#710](#710)) ([b824cac](b824cac)) * enable dora pprof ([#743](#743)) ([2b7be9a](2b7be9a)) * generate keys if not default key is used ([#707](#707)) ([2d1cab5](2d1cab5)) * lodestar persists invalid ssz objects by default ([#730](#730)) ([5a45991](5a45991)) * update egg config parameters ([#737](#737)) ([78c2bc7](78c2bc7)) ### Bug Fixes * add debug ns to nethermind ([#732](#732)) ([372bb52](372bb52)) * allow vc properties in participants_matrix.cl ([#715](#715)) ([c8b9b19](c8b9b19)) * besu devnet schedule ([#734](#734)) ([28b67cd](28b67cd)) * blobscan redis dependency ([#712](#712)) ([0ed1c9c](0ed1c9c)) * change churn limit default for pectra tests ([#747](#747)) ([8109054](8109054)) * correctly apply extra params if builder is enabled ([#725](#725)) ([a94caf0](a94caf0)) * disable all assertoor tests by default ([#738](#738)) ([2961f96](2961f96)) * lodestar vc faster startup ([#721](#721)) ([225e3d8](225e3d8)) * readme eof ([#739](#739)) ([7f94f6e](7f94f6e)) * remove custom peerdas images for dora & assertoor ([#741](#741)) ([a19398d](a19398d)) * remove subscribe all subnet nimbus ([#719](#719)) ([ef92f8f](ef92f8f)) * remove subscribe-all-subnets from default prysm config ([#717](#717)) ([6348c0b](6348c0b)) * remove subscribe-all-subnets lighthouse/lodestar/teku ([#720](#720)) ([cdb20e1](cdb20e1)) * update snapshots URL ([#731](#731)) ([f9269ad](f9269ad)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed it is not possible to run mixed vc<>bn clients if builder / mev is enabled as it applies extra flags from other clients in
vc_extra_paramsas the params are applied based oncl_typebut it should be done based onvc_type.I tested this using the following config with both
mev_type: mockandmev_type: flashbots.