fix: swap http/grpc server ports and replace flags #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skylenet
changed the title
barnabasbusa
approved these changes
Oct 9, 2024
skylenet
pushed a commit
that referenced
this pull request
Nov 1, 2024
🤖 I have created a release *beep* *boop* --- ## [4.4.0](4.3.0...4.4.0) (2024-11-01) ### Features * add checkpoint sync capabilities to nimbus ([#804](#804)) ([853417e](853417e)) * add commit-boost support ([#779](#779)) ([ebbbe83](ebbbe83)) * add docker authentication ([#816](#816)) ([807f6aa](807f6aa)) * add peerdas metrics dashboard ([#790](#790)) ([12b787d](12b787d)) * add rbuilder remove old geth builder - flashbots ([#786](#786)) ([de95c61](de95c61)) * add resource configuration for prometheus and grafana ([#773](#773)) ([d296c26](d296c26)) * add supernode label to every container ([#788](#788)) ([43edfd5](43edfd5)) * add support for fulu/osaka fusaka ([#798](#798)) ([0a9e445](0a9e445)) * add support for remote signers - `use_remote_signer` ([#791](#791)) ([9f1b6e9](9f1b6e9)) * enable one parameter supernode, refactor el,cl,vc ([#778](#778)) ([8513c06](8513c06)) ### Bug Fixes * add database config to assertoor ([#783](#783)) ([56532cf](56532cf)) * add nimbus-eth1 net-key ([#811](#811)) ([c91bbbb](c91bbbb)) * delete unnecessary port assignment for prysm ([#810](#810)) ([47204c3](47204c3)) * docker login to separate action yaml ([#819](#819)) ([2494022](2494022)) * get volume size recommendations when in shadowfork mode ([#820](#820)) ([b1f27c6](b1f27c6)) * mixed up labels ([#799](#799)) ([e2c1528](e2c1528)) * only set supernode if its true ([#796](#796)) ([2110a60](2110a60)) * prefund container suffixes for k8s ([#818](#818)) ([968cfbd](968cfbd)) * remove deprecated http-allow-sync-stalled from LH ([#805](#805)) ([1825dbf](1825dbf)) * Remove not necessary "/api" (and bump verifier version) ([#792](#792)) ([befde97](befde97)) * set default for label-maker ([#797](#797)) ([5b2d234](5b2d234)) * swap http/grpc server ports and replace flags ([#802](#802)) ([8c6df26](8c6df26)) * update built in assertoor tests ([#782](#782)) ([d24fb2a](d24fb2a)) * update nethermind config option ([#824](#824)) ([08ce034](08ce034)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default image:
gcr.io/prysmaticlabs/prysm/beacon-chain:latestalready has thehttp-flags as per prysmaticlabs/prysm#14089I also swapped the ports. Instead of using 3500 for the HTTP server and 4000 for the RPC server ( which is actually prysm's default behaviour). The problem is that all the other CL clients are running their HTTP beacon API under port 4000 (
BEACON_HTTP_PORT_NUM= 4000) . So I think it makes sense to do the same for prysm here.