Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace snark.js with rapidsnark #155

Closed
qzhodl opened this issue Dec 15, 2023 · 3 comments
Closed

Replace snark.js with rapidsnark #155

qzhodl opened this issue Dec 15, 2023 · 3 comments
Assignees
@syntrust
Labels
enhancement New feature or request
Milestone
Devnet-3

Comments

@qzhodl
Copy link
Collaborator

qzhodl commented Dec 15, 2023

Rationale

Go-rapidsnark provides better performance (https://github.com/ethstorage/go-ethstorage/pull/14#issuecomment-1590816080), and our prover can go rid of the nodejs and snarkjs dependencies
@qzhodl qzhodl added the enhancement New feature or request label Dec 15, 2023
@qzhodl qzhodl added this to the Devnet-3 milestone Jan 5, 2024
@qzhodl qzhodl mentioned this issue Jan 8, 2024
Closed
@syntrust
Copy link
Collaborator

syntrust commented Jan 22, 2024 •
edited
Loading

A quick test on MBP 2.9 GHz 6-Core Intel Core i9

Implementation Proof per sample (mode 1) Proof for 2 samples (mode 2)
snarkjs 43.8 60.1
go-rapidsnark 47.1 82.3
rapidsnark 8.2 16.7
  • Perf of rapidsnark improves dramaticly vs snarkjs and go-rapidsnark
  • But both rapidsnark and go-rapidsnark does not support Windows

@syntrust syntrust mentioned this issue Jan 23, 2024
Closed
@syntrust
Copy link
Collaborator

Test result with go-rapidsnark/prover@v0.0.11

platform Proof for 2 samples (mode 2) go version
MBP-AMD 26.8s go1.22.3 darwin/amd64
AX-101 15.6s go1.20.10 linux/amd64

Es-node is built from #281

@syntrust syntrust mentioned this issue Jul 2, 2024
Closed
@syntrust
Copy link
Collaborator

syntrust commented Jul 3, 2024

Solved by #181 and #281

@syntrust syntrust closed this as completed Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syntrust syntrust

Labels
enhancement New feature or request
Projects
None yet
Milestone
Devnet-3
Development

No branches or pull requests
2 participants
@qzhodl @syntrust