Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links caused by ethclient upgrade #16

Closed
syntrust opened this issue Jan 3, 2024 · 2 comments
Closed

Broken links caused by ethclient upgrade #16

syntrust opened this issue Jan 3, 2024 · 2 comments

Comments

@syntrust
Copy link
Collaborator

syntrust commented Jan 3, 2024

Now web3url-gateway uses https://github.com/web3-protocol/web3protocol-go as web3:// engine.

The package now use a up-to-date go-ethereum dependency, and they recently are now using "input" instead of "data" in the JSON-RPC call (apparently "data" was kind of supported but was not the standard). Cf ethereum/go-ethereum#28078 As a consequence, several tests to blockchains ids 1666600000, 1666700000, 100001, 1088, 599, 84531 fails because their RPCs does not recognize "data".

We may need to consider the downgrade of go-ethereum for backward compatibility.

Broken links that were accessible using the old version gateway:

https://0xcf664087a5bb0237a0bad6742852ec6c8d69a27a.hmy-s0.w3link.io/name?returns=(string)

https://0xc2f21f8f573ab93477e23c4abb363e66ae11bac5.qkc-s0.w3link.io/greet?returns=(string)

@nand2
Copy link
Contributor

nand2 commented Jan 4, 2024

And here is the backport of go-ethereum (a few months back) so that it uses "data" again, unbreaking these RPCs. (tests added back, all tests are passing)
PR -> #17

@syntrust
Copy link
Collaborator Author

syntrust commented Jan 5, 2024

#17 is deployed and the links are working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants