Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unified Fides] saas config update initialization action no longer exists #1195

Closed
adamsachs opened this issue Oct 3, 2022 · 3 comments · Fixed by #1213
Closed

[Unified Fides] saas config update initialization action no longer exists #1195

adamsachs opened this issue Oct 3, 2022 · 3 comments · Fixed by #1213
Assignees
Labels
bug Something isn't working Unified Fides

Comments

@adamsachs
Copy link
Contributor

adamsachs commented Oct 3, 2022

Bug Description

In fidesops, on webserver bootup we ran an update "script" for saas configs to pick up any updates coming from a new version of their corresponding templates. See ethyca/fidesops#1307 and associated issue ethyca/fidesops#1098 for more context.

Unless I'm missing something, we seem to have removed this functionality from unified fides. Was there a particular reason for that? We will need this functionality moving forward.

@adamsachs adamsachs added the bug Something isn't working label Oct 3, 2022
@adamsachs
Copy link
Contributor Author

@ThomasLaPiana @pattisdr just looping you in, in case you have any context on whether this was intentional or just an oversight of the merge. i can try to take a stab at adding it back in, just have a couple of things higher on my queue so may take me a bit to get to it

@pattisdr
Copy link
Contributor

pattisdr commented Oct 3, 2022

good catch @adamsachs I assume this was just an oversight

@adamsachs adamsachs self-assigned this Oct 4, 2022
@adamsachs adamsachs changed the title saas config update initialization action no longer exists [Unified Fides] saas config update initialization action no longer exists Oct 4, 2022
@ThomasLaPiana
Copy link
Contributor

I'd also agree it was an oversight, there was code that didn't appear to do anything (tests passed with or without it) so I might've missed reimplementing it, good catch!

@adamsachs adamsachs linked a pull request Oct 5, 2022 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Unified Fides
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants