Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all logger. references to use loguru to stop logs getting suppressed #1842

Closed
seanpreston opened this issue Nov 22, 2022 · 3 comments · Fixed by #2031
Closed

Update all logger. references to use loguru to stop logs getting suppressed #1842

seanpreston opened this issue Nov 22, 2022 · 3 comments · Fixed by #2031
Assignees
Labels
bug Something isn't working

Comments

@seanpreston
Copy link
Contributor

seanpreston commented Nov 22, 2022

When fidesops and fidesctl joined, fidesctl brought with it the library loguru. loguru is now suppressing any vanilla logger. log output. We should investigate converting all logging to use loguru as it's a more performant library.

@adamsachs
Copy link
Contributor

@seanpreston i assume we'll also want to update the logger references in fideslib, e.g. https://github.com/ethyca/fideslib/blob/main/fideslib/oauth/api/routes/user_endpoints.py ?

@pattisdr
Copy link
Contributor

@adamsachs good callout - simultaneously fideslib is being moved into fides #1859

@pattisdr pattisdr removed their assignment Dec 12, 2022
@seanpreston
Copy link
Contributor Author

@seanpreston i assume we'll also want to update the logger references in fideslib, e.g. https://github.com/ethyca/fideslib/blob/main/fideslib/oauth/api/routes/user_endpoints.py ?

Thanks, I'd left that out for the reason that Dawn mentions

@adamsachs good callout - simultaneously fideslib is being moved into fides #1859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants