Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity verification pop-up doesn't close and errors out on multiple submit clicks #2219

Closed
saiatethyca opened this issue Jan 12, 2023 · 2 comments · Fixed by #2401
Closed
Assignees
Labels
bug Something isn't working customer-request A feature or bug-fix requested by a customer

Comments

@saiatethyca
Copy link

Bug Description

Identify verification pop-up doesn't close and errors out on multiple submit clicks. This seems to happen when the manual approval process is disabled.

Steps to Reproduce

  1. Disable the manual approval process.
  2. Start any DSR request and enter the verification code in the UI pop-up.
  3. Click submit once and see that the pop-up doesn't close.
  4. Click on submit again and see that the pop-up closes but an error banner is shown in the UI.
  5. DSR request is successfully triggered.

Expected behavior

  1. Pop-up should be closed on the first click of submit button, and there shouldn't be any error banner in the UI.

Screenshots

image-20230105-182439

@saiatethyca saiatethyca added the bug Something isn't working label Jan 12, 2023
@saiatethyca saiatethyca changed the title Identify verification pop-up doesn't close and errors out on multiple submit clicks Identity verification pop-up doesn't close and errors out on multiple submit clicks Jan 12, 2023
@Roger-Ethyca
Copy link
Contributor

@Roger-Ethyca look into this with masking_strict = false

@Kelsey-Ethyca
Copy link
Contributor

Kelsey-Ethyca commented Jan 25, 2023

I was able to repo this.. you need to click rapidly on step 3 and 4. The problem is the verification code is being submitted more than once so it is invalid the second time. I would consider disabling the 'Submit code' btn after initial click.

@NevilleS NevilleS added the customer-request A feature or bug-fix requested by a customer label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working customer-request A feature or bug-fix requested by a customer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants