Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a footer to documentation pages that encourages contributions #260

Closed
PSalant726 opened this issue Nov 29, 2021 · 4 comments · Fixed by #265
Closed

Add a footer to documentation pages that encourages contributions #260

PSalant726 opened this issue Nov 29, 2021 · 4 comments · Fixed by #265
Assignees
Milestone

Comments

@PSalant726
Copy link
Contributor

In an effort to streamline the maintenance of fidesctl documentation, each page should include a footer that encourages readers to open a PR that corrects mistakes and/or updates outdated information. Ideally the footer dynamically links to the markdown file currently being viewed, in the fides repository.

@iamkelllly
Copy link
Contributor

Also adding to scope here to have a link to the Github repo

@iamkelllly iamkelllly added this to the fidesctl 1.2 milestone Nov 30, 2021
@ThomasLaPiana ThomasLaPiana self-assigned this Dec 2, 2021
@brentonmallen1
Copy link
Contributor

When attempting to serve the docs, I did a make clean but I'm still getting the FATAL: password authentication failed for user "postgres" error when attempting to build. I thought that was fixed but I could have missed something.

@ThomasLaPiana
Copy link
Contributor

not sure how to help with that one, we made some changes but it was awhile ago, and the make clean should've fixed it 🤔 are you testing this PR?

@brentonmallen1
Copy link
Contributor

I was attempting to do so by doing a make docs-serve but ran into the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants