Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tech debt - remove type: ignore comments that work around click library issue #3749

Open
adamsachs opened this issue Jul 7, 2023 · 0 comments

Comments

@adamsachs
Copy link
Contributor

Is your feature request related to a specific problem?

In #3746 we worked around a known mypy issue introduced by click version 8.1.4 by adding in comments to ignore type checking with some of our click decorators -- see #3745 and pallets/click#2558.

Describe the solution you'd like

Once pallets/click#2558 is resolved and released in a new version of click, we should be able to (and should automatically) pull in that updated dependency, and be able to revert our workaround here, such that we're no longer ignoring type checking on these lines.

Describe alternatives you've considered, if any

Keep things as is - this has a pretty minor impact, really just code maintenance.

Additional context

more context in #3745 and pallets/click#2558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants