Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake files are not generated #29

Open
wirew0rm opened this issue Feb 4, 2019 · 3 comments
Open

Cmake files are not generated #29

wirew0rm opened this issue Feb 4, 2019 · 3 comments

Comments

@wirew0rm
Copy link

wirew0rm commented Feb 4, 2019

After compilation there are no cmake files in ./devel/lib/cmake/glog and it is impossible to do find_package(glog 0.3.5 REQUIRED) in packages depending on glog in the same workspace as described here.

I could not find the difference to gflags_catkin, where everything works as expected.

I'm on ubuntu 18.04 lts xenial and ROS kinetic, using catkin build to build gflags_catkin and glog_catkin.

Minimal example to reproduce:

mkdir -p  ~/testws/src
cd ~/testws
catkin init
wstool init src
wstool set -t src catkin_simple --git https://github.com/catkin/catkin_simple.git
wstool set -t src gflags_catkin --git https://github.com/ethz-asl/gflags_catkin.git
wstool set -t src glog_catkin --git https://github.com/ethz-asl/glog_catkin.git
wstool update -t src
catkin build
ls -R devel/lib/cmake/

produces:

devel/lib/cmake/:
    gflags
devel/lib/cmake/gflags:
    gflags-config.cmake  gflags-config-version.cmake  gflags-targets.cmake  gflags-targets-release.cmake

I would expect to also see a glog subfolder containing .cmake files for glog.

@wirew0rm
Copy link
Author

wirew0rm commented Feb 4, 2019

This seems to be intended behaviour when not building with cmake but with autotools, according to google/glog#398 (comment)
I'll try to migrate to using CMake for the build to get cmake files.

@wirew0rm
Copy link
Author

wirew0rm commented Feb 7, 2019

I fixed this in tu-darmstadt-ros-pkg@82760fa by using CMake to build, but now static libraries are not built and the documentation is not installed.

I did not find an easy way to add them to the cmake output and as for us only the dynamic library and the cmake files are important I cannot investigate further.

@antbono
Copy link

antbono commented Nov 30, 2019

Thank you! I had the same problem with the glog package by eth. Your version worked for me.
BTW are you ok with kinetic on ubuntu 18.04?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants