Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NG 15 themes should match the legacy themes #156

Closed
daileytj opened this issue Mar 1, 2023 · 3 comments · Fixed by #192
Closed

NG 15 themes should match the legacy themes #156

daileytj opened this issue Mar 1, 2023 · 3 comments · Fixed by #192
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement New feature or request
Milestone

Comments

@daileytj
Copy link
Contributor

daileytj commented Mar 1, 2023

Describe the desired feature/functionality

After updating to NG15 and Angular Material v15, Angular Material components, and Brightlayer UI components should still look the same as they did on v14.

Additional Context (where / how would this be used)

Is this request related to a current issue?

etn-ccis/blui-angular-showcase-demo#303 (comment)

Suggested implementation details

@daileytj daileytj added enhancement New feature or request needs-review Issues that we would like to revisit/review brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering labels Mar 1, 2023
@daileytj daileytj added this to the 9.0.0 milestone Mar 1, 2023
@joebochill
Copy link
Collaborator

@daileytj is this something we need an issue for, or should it just be part of the acceptance criteria for the PR that is still open? I.e., are we going to accept that PR as-is and then take this issue to handle cleanup?

@daileytj
Copy link
Contributor Author

daileytj commented Mar 2, 2023

@daileytj is this something we need an issue for, or should it just be part of the acceptance criteria for the PR that is still open? I.e., are we going to accept that PR as-is and then take this issue to handle cleanup?

The PR that is (was) open was a showcase-demo project. In order to fix these properly we will need updates to the theme so I wrote this issue to capture the work that still needs to be done before officially publishing.

@JeffGreiner-eaton JeffGreiner-eaton removed the needs-review Issues that we would like to revisit/review label Mar 16, 2023
@JeffGreiner-eaton
Copy link
Collaborator

I tried finding an open issue for this but didn't.
The .cdk-overlay-backdrop-showing.blui-user-menu-bottomsheet-backdrop is getting trumped by .blui-blue .cdk-overlay-backdrop.cdk-overlay-backdrop-showing and setting opacity to 1 but instead should be .5 and displaying a solid background

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

3 participants