Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme color and styles are not proper #191

Open
RaghavendranC-Eaton opened this issue Jul 4, 2023 · 0 comments
Open

Dark theme color and styles are not proper #191

RaghavendranC-Eaton opened this issue Jul 4, 2023 · 0 comments

Comments

@RaghavendranC-Eaton
Copy link
Contributor

          I will just spill out every single thing I noticed. Many of these might be out of scope; feel free to defer for future improvements (or just sit on it and wait for ng16, material design 3)

1. Progress Bar

Dark theme only. Accent color is using 200 colors, unlike the default and primary.

image

2. Sliders

Same issue
image

3. Bottom sheet

Probably not an issue. I just noticed the bottom sheet is still LTR in a RTL setting
image

4. FAB

Perfectionist moment! The icon is not vertically centered with a 0.86px vertical offset. This applies to all variants and both FAB components (regular FABs and mini FABs)
image
image

5. Text Field

Applies to both light and dark theme:
image

6. Text Field (2)

Dark theme only:
image

Originally posted by @huayunh in #188 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant