Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match React's Mat-Table Sort Arrow Styles #73

Open
emclaug2 opened this issue Feb 1, 2022 · 1 comment
Open

Match React's Mat-Table Sort Arrow Styles #73

emclaug2 opened this issue Feb 1, 2022 · 1 comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement New feature or request

Comments

@emclaug2
Copy link
Contributor

emclaug2 commented Feb 1, 2022 •
edited
Loading

Describe the desired behavior

The current <mat-table> sortable column header styles do not match React's.

Describe the current behavior

The arrow indicating which column is actively sorted does not persist. Once a column is sorted, the arrow should remain visible, even when not hovered.

How to recreate

  1. Make a sortable table with our theme applied.
  2. Sort a column.
  3. Observe the arrow, indicating which column is sorted (ascending or descending) does not persist.

Is this request related to a current issue?

No

Screenshot

This is what Reacts sortable column header looks like.

image
@emclaug2 emclaug2 added enhancement New feature or request needs-review Issues that we would like to revisit/review labels Feb 1, 2022
@emclaug2
Copy link
Contributor Author

emclaug2 commented Feb 1, 2022

TODO: Add a picture of React vs Angular.

@jeffvg jeffvg removed the needs-review Issues that we would like to revisit/review label Feb 16, 2022
@emclaug2 emclaug2 added this to the 7.0.2 milestone Apr 15, 2022
@emclaug2 emclaug2 removed this from the 7.0.2 milestone Nov 21, 2022
@joebochill joebochill added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emclaug2 @joebochill @jeffvg