Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark theme blue drawer header should use white text #79

Closed
huayunh opened this issue Feb 3, 2022 · 1 comment · Fixed by #163
Closed

Dark theme blue drawer header should use white text #79

huayunh opened this issue Feb 3, 2022 · 1 comment · Fixed by #163
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something isn't working
Milestone
8.1.0

Comments

@huayunh
Copy link
Contributor

huayunh commented Feb 3, 2022 •
edited by emclaug2
Loading

Describe the bug

The text inside of a <blui-drawer-header> is the incorrect color.

What is the expected behavior?

Should be white50. Anything on blue should be white50 in dark theme

How to recreate

  1. Navigate to the showcase app, here.
  2. Enable dark mode
  3. Observe the DrawerHeader (very carefully) and notice that it is the incorrect color.

Proof

image
The text is black50
@huayunh huayunh added bug Something isn't working needs-review Issues that we would like to revisit/review labels Feb 3, 2022
@emclaug2
Copy link
Contributor

emclaug2 commented Feb 3, 2022

The icon should also be white[50]

@huayunh huayunh changed the title Dark theme primary app bar should use white text Dark theme blue drawer header should use white text Feb 11, 2022
@jeffvg jeffvg removed the needs-review Issues that we would like to revisit/review label Feb 16, 2022
@emclaug2 emclaug2 added this to the 7.0.2 milestone Apr 15, 2022
@emclaug2 emclaug2 self-assigned this Jun 7, 2022
@emclaug2 emclaug2 modified the milestones: 7.0.2, 8.0.1 Nov 21, 2022
@joebochill joebochill added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Jan 5, 2023
@raghavenc5 raghavenc5 mentioned this issue Mar 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something isn't working
Milestone
8.1.0
4 participants
@emclaug2 @huayunh @joebochill @jeffvg