Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the transparent invisible square in SVGs #197

Open
huayunh opened this issue Mar 29, 2022 · 4 comments
Open

Remove the transparent invisible square in SVGs #197

huayunh opened this issue Mar 29, 2022 · 4 comments
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement Request for improvement or new feature

Comments

@huayunh
Copy link
Contributor

huayunh commented Mar 29, 2022

Describe the desired behavior

Remove all the invisible squares from icons in the svg folder. People using PowerPoint cannot import icons into PPT and change color due to this extra square element "<path fill="none" d="M0 0h24v24H0z"/>" (or its equivalent)

Describe the current behavior

It was there because React Native had some specific requirements for icon buttons.

Is this request related to a current issue?

MarComm proposed in a MarComm discussion
@huayunh huayunh added enhancement Request for improvement or new feature needs-review Issues that we would like to revisit/review labels Mar 29, 2022
@huayunh
Copy link
Contributor Author

huayunh commented Mar 30, 2022

See file changes from https://github.com/brightlayer-ui/icons/pull/88 for a headstart

@bkarambe
Copy link
Contributor

@huayunh Any updates on this one?

@bkarambe bkarambe removed the needs-review Issues that we would like to revisit/review label Apr 27, 2022
@huayunh
Copy link
Contributor Author

huayunh commented Apr 27, 2022 •
edited
Loading

No, this issue is still valid. What updates are you looking for, @bkarambe ?

@bkarambe
Copy link
Contributor

This issue still exists.

@joebochill joebochill added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement Request for improvement or new feature
Milestone
No milestone
Development

No branches or pull requests
3 participants
@huayunh @bkarambe @joebochill