Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChangePasswordDialog is missing BLUI class names #600

Closed
joebochill opened this issue Jun 17, 2024 · 2 comments
Closed

ChangePasswordDialog is missing BLUI class names #600

joebochill opened this issue Jun 17, 2024 · 2 comments
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected

Comments

@joebochill
Copy link
Collaborator

Describe the bug / expected behavior

The ChangePassword dialog does not have any BluiXXX-xxx classNames on the structural elements, making it impossible to do any style overriding that targets this particular component only.

What are the steps to reproduce?

  1. Try to style part of the ChangePasswordDialog with CSS
  2. Observe that there is no way to target this particular dialog without affecting all other dialogs

Suggested fix

Use the useUtilityClasses construction that we use in other components to generate the set of classes for various structural elements in the dialog.

Anything else to add?

This was observed in the ChangePasswordDialog, but may be an issue in other components as well. Check elsewhere when fixing this to see if there are other areas that need the same update,

@joebochill joebochill added bug Something not working as expected needs-review Issues that we would like to revisit/review brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering labels Jun 17, 2024
@surajeaton
Copy link
Collaborator

@surajeaton Check other components for the same issue.

@surajeaton surajeaton removed the needs-review Issues that we would like to revisit/review label Jun 26, 2024
@ektaghag-eaton
Copy link
Contributor

Fixed here #613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering bug Something not working as expected
Development

No branches or pull requests

3 participants