Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature to MeanTransform #39

Closed
2 tasks done
Mr-Geekman opened this issue Aug 14, 2023 · 2 comments
Closed
2 tasks done

add feature to MeanTransform #39

Mr-Geekman opened this issue Aug 14, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@Mr-Geekman
Copy link

Issue by TsoyAlV
Saturday Jul 22, 2023 at 20:42 GMT
Originally opened as tinkoff-ai#1326


🚀 Feature Request

It is not possible to take average data for a certain period (start, stop).
Important!
The function "MeanTransform" takes data from future

Proposal

  • 1) First of all, I want data not taken from the future
  • 2) Add option to select averaging period

Test cases

No response

Additional context

image

@Mr-Geekman Mr-Geekman added the enhancement New feature or request label Aug 14, 2023
@Mr-Geekman
Copy link
Author

Comment by Mr-Geekman
Wednesday Jul 26, 2023 at 09:53 GMT


Hello!
If you want for MeanTransform not to use data for the current timestamp you can do it by applying MeanTransform to lagged values.
In that case you create lagged values using LagTransform(in_column="column_name", lags=[my_lag], out_column="lag") and then add MeanTransform(in_column=f"lag_{my_lag}", window=my_window).

Add option to select averaging period

Can you elaborate on this? We have window parameter, isn't it enough?

@d-a-bunin
Copy link
Collaborator

It seems like this question is very stale and could be closed.

@d-a-bunin d-a-bunin closed this as not planned Won't fix, can't repro, duplicate, stale Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants