Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

More sophisticated regEx #5

Open
davidhund opened this issue Feb 8, 2015 · 2 comments
Open

More sophisticated regEx #5

davidhund opened this issue Feb 8, 2015 · 2 comments

Comments

@davidhund
Copy link

I noticed was that your regular expressions are very naive: e.g. it picked up the following rule:

.some-rule {
    background: #fff url('../img/bg_creme.png') repeat-x 0 0;
}

and —because the regEx simply matches rem in the property value— warned about using REM.

One (still simplistic) way to improve this specific regex would be to check for /\drem/.

This would probably go for most other tests...

@etodanik
Copy link
Owner

etodanik commented Feb 8, 2015

right, that's true.

If you have some spare time and want to submit a Pull Request, it is very straight forward to edit the regex. There is a hash of them here:
https://github.com/israelidanny/ie8linter/blob/master/specs/unsupported-css.js

otherwise I'll probably do it over the course of the weeek.

@davidhund
Copy link
Author

Yup, I'll see what I can do.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants