Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pazi weighting of matchers vs frecency is icky #63

Open
euank opened this issue Mar 15, 2018 · 0 comments
Open

Pazi weighting of matchers vs frecency is icky #63

euank opened this issue Mar 15, 2018 · 0 comments

Comments

@euank
Copy link
Owner

euank commented Mar 15, 2018

I think the weighting is a bit bad.

The relevant code is:

pazi/src/frecent_paths.rs

Lines 174 to 176 in 69d54c0

.filter_map(move |m| match m.matches(item.0, filter) {
Some(v) => Some((item.0, v * 0.8 + item.1 * 0.2)),
None => None,

One obvious case this does poorly in is the certs and cert-manager folders I have. Even when my cert-manager folder has a higher frecency, typing z cert drops me in certs because the substring matcher weights that so much more highly.

I think a series of unit tests could help define what the right thing is, but at the very least tweaking the weights a bit for now is a good first step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant