Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debowerify npm package mismatch #80

Open
rovens opened this issue Mar 5, 2016 · 1 comment
Open

debowerify npm package mismatch #80

rovens opened this issue Mar 5, 2016 · 1 comment

Comments

@rovens
Copy link
Collaborator

rovens commented Mar 5, 2016

Hi everyone,
I could be completely missing something here, but it looks the debowerify package at npm has drifted from the current master. Specifically, it does not include the preferNPM property to favor npm dependencies over bower ones.

Version 1.3.1 was published to NPM 9 months ago. The pull request for preferNPM occurred 4 months ago.
@eugeneware Are you able to publish to npm, so the latest package has this feature? Or if i'm doing something stoopid, correct my stoopid?

Thanks! :-)

@eugeneware
Copy link
Owner

Hey @rovens - The issue was that the code was merged, but not published with a new version. I've bumped the version to 1.4 and published. Sorry!

For future reference (as debowerify is an Open Open Source Project), after a merge to master (and all the tests pass of course!) we need to:

  1. update package.json with the new semver version.
  2. Tag the release with the version number and git push, git push --tags and then npm publish
  3. If the contribution is not a collaborator, give the originator of the PR collaborator access to the repo.

@rovens I've added you to the Contributor list on the README, and added you as a collaborator. If you'd like npm publish access, please let me know what your npm username is.

And have a read through the Open Open Source thread to see how this is all supposed to work (or in this case didn't LOL!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants