Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable refresh #41

Closed
Emoun opened this issue May 10, 2020 · 3 comments · Fixed by #42
Closed

Configurable refresh #41

Emoun opened this issue May 10, 2020 · 3 comments · Fixed by #42
Assignees

Comments

@Emoun
Copy link
Contributor

Emoun commented May 10, 2020

I would be useful if we were able to configure whether the "refresh" outcome of expand could be turned off or result in a failure.

I specifically have a setup where I'd rather have a missing .expanded.rs file trigger a test failure and not create the expanded file for me. I like that the file could be created for me, but I'd prefer if it was only when I specifically ask for it.

A possible solution is simply adding another method that doesn't create expanded files when they are missing, simply failing instead:

#[test]
pub fn pass() {
    macrotest::expand_without_refresh("tests/expand/*.rs");
}
@eupn
Copy link
Owner

eupn commented May 10, 2020

@Emoun

Sure, it seems straightforward to implement.

@eupn eupn self-assigned this May 10, 2020
@eupn eupn closed this as completed in #42 May 10, 2020
@Emoun
Copy link
Contributor Author

Emoun commented May 10, 2020

@eupn Thanks for the quick response and implementation. It seems to work as expected for me.
Much appreciated.

@eupn
Copy link
Owner

eupn commented May 10, 2020

@Emoun sure, thank you for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants