Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Dark Reader? #2

Open
oskarsh opened this issue Jun 7, 2019 · 2 comments
Open

Support for Dark Reader? #2

oskarsh opened this issue Jun 7, 2019 · 2 comments

Comments

@oskarsh
Copy link
Contributor

oskarsh commented Jun 7, 2019

Hey another nice feature would be an integration with Dark Reader Extension. This is one of the most used Extension when it comes to Webpage Darkmode and is also open source.
You can send calls to the extension if you expose a API and can trigger Dark Mode. This involves alot of work and knowledge but would achieve a truly universal Dark Mode.

DarkReader Repository

@evan-buss
Copy link
Owner

Unless the extension exposes some API that allows you to toggle it, I don't really want to create some sort of patch-job that allows it to work. I feel that it would be more work than it's worth.

There are also a bunch of different extensions that switch the browser CSS and it would be out-of-place to support a single browser extension. In my opinion, Yin-Yang should provide more general light-and-dark functionality for the operating system. Thank you for the suggestion though.

@oskarsh
Copy link
Contributor Author

oskarsh commented Jun 8, 2019

Yes I can totally understand and respect that decision. The Feature would be really nice but would cost to much work. You could leave this Issue open, I am sure someone who is willing to contribute to this Project will tackle this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants