-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stack overflow - last zone 4 encounter #121
Comments
After restart, issue continues |
Can I have the save file? This could be really helpful to have if the issue is easily reproducible upon restart. |
Skyland.srm.txt |
Did you start a new game afterwards? Are you using an overdrive? This version of the save file is not saved at a state right before the crash happens. |
Sometimes with an everdrive, some models will write files back to the sd card upon the next time that the game is loaded, could this be an older version of the save file? |
Unfortunately, this issue is possibly my recursive merge-sort function skyland-beta/scripts/stdlib.lisp Line 116 in 21ff1dd
I'll rewrite it to use the C++ sort function. My lisp sort function was so concise and pretty, RIP |
might be the case, this looks like the same game, but 1 zone before. |
is this the lisp api backend? |
Some of the lisp api is written in lisp. I'll have to replace this function with C++ code, because it's using too much stack space. |
#118 |
So this is when the stack overflow is not detected? |
Possibly, yeah. I do my best to detect stack overflows, but it's imprecise and quite difficult. There's no operating system on the gba and I have to do some manual checks to see if sentinel values placed at the end of the stack get trampled upon. Certain patterns of writes can skip over the memory locations that I use to detect invalid stack writes, preventing the stack overflow detection logic from working. Due to lack of hardware memory protection support in the gameboy, this is the best I can do. |
Stack overflow after accepting delivery quest

The text was updated successfully, but these errors were encountered: