Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested waitUntil not correctly awaited #7

Closed
hansottowirtz opened this issue Jun 16, 2023 · 1 comment · Fixed by #8
Closed

Nested waitUntil not correctly awaited #7

hansottowirtz opened this issue Jun 16, 2023 · 1 comment · Fixed by #8

Comments

@hansottowirtz
Copy link
Contributor

Due to this line I believe nested waitUntils are not correctly awaited:

async wait() {
await Promise.all(this._outstandingPromises)
}

It's exactly the same issue as here:
cloudflare/miniflare#605

I'll open a PR implementing this code.

@evanderkoogh
Copy link
Owner

Doh!

awesome catch! I am hot on the tail of a fix for the wrangler 3 issue so once I fixed that I’ll merge this and get a release out. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants