Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support install without post-install #1270

Closed
hardfist opened this issue May 11, 2021 · 2 comments · Fixed by #1621
Closed

support install without post-install #1270

hardfist opened this issue May 11, 2021 · 2 comments · Fixed by #1621

Comments

@hardfist
Copy link
Contributor

It seems that esbuild relys post-install to download the real bin for arch-spec bin file, which cause some troubles

  • npm7 problem
  • not support offline install

I wonder whether is there better ways to handle this?

@hardfist
Copy link
Contributor Author

It seems library like esbuild-linux-64 is not a standalone esbuild library(which only contains bin file), which makes npm alias like esbuild: "npm:esbuild-linux-64" not working, which is suitable for offline install

@evanw
Copy link
Owner

evanw commented May 11, 2021

  • npm7 problem

I assume you're talking about npm/cli#2606. One idea for an alternative implementation of esbuild's installer is #789. Unfortunately that approach hits another npm bug: npm/cli#2707. Although that has been fixed, lots of people are probably still using that buggy version of npm. It may be impossible to have a way to install esbuild that never hits npm bugs because of the way npm's bugs overlap.

I agree that adding the JavaScript APIs to all of the individual platform-specific packages may mitigate this issue somewhat. It's not a complete solution, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants