Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

var(--tw-empty,/*!*/ /*!*/) wrongly processed #760

Closed
monken opened this issue Feb 6, 2021 · 3 comments
Closed

var(--tw-empty,/*!*/ /*!*/) wrongly processed #760

monken opened this issue Feb 6, 2021 · 3 comments

Comments

@monken
Copy link

monken commented Feb 6, 2021

TailwindCSS uses this workaround to set the value of a CSS variable to a single empty space:

--tw-ring-inset: var(--tw-empty,/*!*/ /*!*/);

which is translated by esbuild into (minify: false)

--tw-ring-inset: var(--tw-empty,);

which is not valid and should instead be left untouched.

There are more details around this in the following ticket:

tailwindlabs/tailwindcss#2889

@evanw
Copy link
Owner

evanw commented Feb 7, 2021

Wow what a crazy edge case. Thanks for the heads up. I’ll make sure this is fixed in one of the upcoming releases.

@evanw evanw closed this as completed in 24f2305 Feb 8, 2021
@monken
Copy link
Author

monken commented Feb 8, 2021

Wow, thanks for fixing this so fast!

@sebastienbarre
Copy link

Thanks @evanw for putting this in 0.8.43; coincidentally I just noticed this very issue today while using Tailwind's ring utilities. Snowpack still uses esbuild 0.8.7, but nothing resolution can't fix temporarily in my package.json...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants