[Bug] Unreachable code not removed after If/Else

[tobymao]

var test = function(x) { if (x == 1 ) {
    return "a"
  } else {
    return "b"
  }

  return null;
}

test(1)

esbuild a.js --minify

var test=function(r){if(r==1)return"a";return"b";return null};test(1);

esbuild a.js --minify --bundle

(()=>{var e=function(r){if(r==1)return"a";return"b";return null};e(1);})();

In both cases, --minify should remove the final return null because it is unreachable.

[evanw]

Huh, yeah that looks like a bug. Seems like it'll be easy to fix.

[evanw]

The next release will generate this code:

var test=function(r){return r==1?"a":"b"};test(1);

[tobymao]

Wow amazingly quick fix. Will this work without bundle as well? I don't use --bundle in my app.

[evanw]

Yeah this shouldn’t depend on the bundle setting.