Update to stable tokio 1.0 by bumping reqwest #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clippy says it is the default for constant, thus needless.
These are not directly used in the crate, thus there is no need to mention them in Cargo.toml. They are still pulled in my our dependencies (reqwest), but that's cargo's job, not ours.
Note that version "0.11" means 0.11 <= version < 0.12, which gives most flexibility to downstream crates (they may want to pin specific version etc).
strohel
force-pushed
the
update-to-stable-tokio
branch
from
7105b7d
to
c122c3a
Compare
|
Looks great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review by individual commits.
I've sneaked in one little cleanup, I can drop it if not desired.