Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align schema handling with prooph event store #5

Open
codeliner opened this issue Dec 3, 2019 · 1 comment
Open

Align schema handling with prooph event store #5

codeliner opened this issue Dec 3, 2019 · 1 comment

Comments

@codeliner
Copy link
Contributor

The document store performs a mb_strtolower when extracting the schema, see here: https://github.com/event-engine/php-postgres-document-store/blob/master/src/PostgresDocumentStore.php#L774

Prooph's event store uses the schema as-is. That said, when using the MultiModelStore this can lead to problems and confusion.

We need to address the issue.

Options

  1. Remove mb_strtolower (breaking change, but it's relatively new behavior, so maybe not a big deal)
  2. Modify ProophEventStore wrapper and perform a mb_strtolower before passing the schema name to prooph's event store
@codeliner
Copy link
Contributor Author

ping @sandrokeil @heiglandreas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant