Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fake data with Ban users #559

Closed
BlagovestGerov opened this issue May 31, 2019 · 5 comments
Closed

Add fake data with Ban users #559

BlagovestGerov opened this issue May 31, 2019 · 5 comments
Assignees
Labels
scope: admin Admin UI scope scope: server Server / API scope type: enhancement ✨ New feature or request
Milestone

Comments

@BlagovestGerov
Copy link
Contributor

Basically, randomly make few customers to be banned customers during fake data generation

@BlagovestGerov BlagovestGerov added type: enhancement ✨ New feature or request scope: server Server / API scope scope: admin Admin UI scope labels May 31, 2019
@evereq
Copy link
Member

evereq commented Jun 3, 2019

@AdemHodzic It looks like no fake Banned users are generated.

Reported by @BlagovestGerov: "I dropped the Database several times but after generating again fake data I didn’t find fake generated banned users."

Badge

@AdemHodzic
Copy link
Contributor

Hmm, well this is quite random so I would guess he was just unlucky lol
But seriously, I didn't change any previous functionality. I just introduced a new field.
Did it persist to the database before?

@evereq
Copy link
Member

evereq commented Jun 4, 2019

@AdemHodzic I think the issue here is that random values you generate somehow always get constant value (e.g. false) and so we don't really see any fake generated banned users :) You need to run it locally and see if some of the fake records get banned = true...

@evereq
Copy link
Member

evereq commented Jun 5, 2019

@AdemHodzic so as we discover it looks like for at least generate100users we see around 4 banned users from 100... But seems when we generate all fake data we don't see such users... Could be we have other methods which generate random users and we need to add "random" banned there too :)

@AdemHodzic
Copy link
Contributor

AdemHodzic commented Jun 5, 2019

I just found out we are using a different method in generateAll. In this case, we are using a graphql mutation and in other, we are using plain HTTP request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: admin Admin UI scope scope: server Server / API scope type: enhancement ✨ New feature or request
Projects
Development

No branches or pull requests

3 participants