Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Replace Error Dialog with Toaster Notification for Advanced Settings Error #8247

Open
rahul-rocket opened this issue Sep 24, 2024 · 4 comments · Fixed by #8727
Assignees

Comments

@rahul-rocket
Copy link
Collaborator

Description:
The current error handling for the advanced settings step displays an intrusive error dialog box when an issue occurs. This needs to be replaced with a more user-friendly and non-intrusive toaster notification.

Tasks:

  1. Replace the error dialog with a toaster notification.
  2. Provide a more human-readable error message:
  • Current Message: "You provided 'undefined' where a stream was expected. You can provide an Observable, Promise, ReadableStream, Array, AsyncIterable, or Iterable."

  • Updated Message: "An unexpected error occurred while processing your request. Please make sure all required settings are properly configured."

  1. Ensure that the new toaster notification styling matches the overall theme of the application.

image

@syns2191
Copy link
Collaborator

syns2191 commented Feb 2, 2025

error notify already changed to toast

Image Image

@syns2191 syns2191 linked a pull request Feb 2, 2025 that will close this issue
2 tasks
@rahul-rocket
Copy link
Collaborator Author

@syns2191 Why this Toaster Notification saying "Ever Teams Timer"?

@nyomansutralia-jubelio
Copy link

yes i have build this app with my custom env value.

DESKTOP_TIMER_APP_NAME='ever-teams-timer' DESKTOP_TIMER_APP_DESCRIPTION='Ever Teams Timer' DESKTOP_TIMER_APP_ID='com.ever.everteamstimer' DESKTOP_TIMER_APP_REPO_NAME='ever-teams-timer' DESKTOP_TIMER_APP_REPO_OWNER='ever-co'

@rahul-rocket
Copy link
Collaborator Author

@nyomansutralia-jubelio Okay. We can close this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants