Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Maruku attribute lists don't seem to work #186

Open
aendra-rininsland opened this issue Mar 17, 2014 · 3 comments
Open

Inline Maruku attribute lists don't seem to work #186

aendra-rininsland opened this issue Mar 17, 2014 · 3 comments

Comments

@aendra-rininsland
Copy link

According to the Maruku metadata proposal, the following:

### Header ###     {: #myid}

...Should translate to:

<h3 id="myid">Header</h3>

However:

markdown.toHTML('### Header ###     {: #myid}', 'Maruku');

...Instead yields:

"<h3>Header ###     {: #myid}</h3>"

...Leading me to believe something's broken in 0.6.0-beta1.

Worth noting that adding a newline before the metadata makes everything work swimmingly.

@aendra-rininsland
Copy link
Author

Experimenting with it a bit more, images, links and other inline content requires that the metadata block be right next to the element, without any whitespace. You in fact need to do this, or else the metadata will get applied to the next paragraph.

Even if the implementation is left as-is, there really needs to be some documentation about it.

@ashb
Copy link
Collaborator

ashb commented Mar 17, 2014

Okay yes one of two things need fixing there.

Form what I remember of the maruku docs properties for block level elements (i.e. the h3) need to be the line below the element.

Could you work out how the official ruby maruku gem behaves for these cases please?

@ashb
Copy link
Collaborator

ashb commented Mar 17, 2014

Oh header is right there in the example - yeah so that looks like a bug then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants