Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Fix unit test non-determinism #1446

Closed
fedekunze opened this issue Nov 9, 2022 · 1 comment · Fixed by #1447
Closed

Fix unit test non-determinism #1446

fedekunze opened this issue Nov 9, 2022 · 1 comment · Fixed by #1447
Labels
good first issue Good for newcomers help wanted Extra attention is needed pinned Pinned issues that won't be closed by stalebot Type: Tests issues and PR related to tests

Comments

@fedekunze
Copy link
Contributor 

--- FAIL: TestKeyring (0.22s)
    algorithm_test.go:78: 
        	Error Trace:	/home/runner/work/ethermint/ethermint/crypto/hd/algorithm_test.go:78
        	Error:      	Not equal: 
        	            	expected: "0x6306EcD6E3d3E269C6E1328951873Eb3AEDd0DD2"
        	            	actual  : "0xaFF332245CD714842BF88374ea62f131ec906c49"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-0x6306EcD6E3d3E269C6E132895[187](https://github.com/evmos/ethermint/actions/runs/3429370302/jobs/5714895630#step:5:188)3Eb3AEDd0DD2
        	            	+0xaFF332245CD714842BF88374ea62f131ec906c49
        	Test:       	TestKeyring
FAIL
coverage: 86.2% of statements
@fedekunze fedekunze added good first issue Good for newcomers help wanted Extra attention is needed Type: Tests issues and PR related to tests pinned Pinned issues that won't be closed by stalebot labels Nov 9, 2022
@fedekunze fedekunze moved this to 📋 Backlog in Ethermint Board Nov 9, 2022
@fedekunze fedekunze moved this from 📋 Backlog to 🧐 Triaged in Ethermint Board Nov 9, 2022
@mmsqe mmsqe mentioned this issue Nov 10, 2022
Merged
11 tasks
@GAtom22 GAtom22 self-assigned this Nov 14, 2022
@GAtom22 GAtom22 moved this from 🧐 Triaged to 🏗 In progress in Ethermint Board Nov 14, 2022
@GAtom22 GAtom22 removed their assignment Nov 14, 2022
@GAtom22
Copy link
Collaborator

GAtom22 commented Nov 14, 2022

Already being addressed in PR #1447

@GAtom22 GAtom22 moved this from 🏗 In progress to 👀 In review in Ethermint Board Nov 14, 2022
Repository owner moved this from 👀 In review to ❌ Canceled in Ethermint Board Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed pinned Pinned issues that won't be closed by stalebot Type: Tests issues and PR related to tests
Projects
No open projects
Ethermint Board
Status: ❌ Canceled
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: enable fixIssue172 flag for test mmsqe/ethermint
2 participants
@fedekunze @GAtom22