Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Add miner_ endpoints to docs #477

Closed
fedekunze opened this issue Aug 23, 2021 · 1 comment · Fixed by #481
Closed

Add miner_ endpoints to docs #477

fedekunze opened this issue Aug 23, 2021 · 1 comment · Fixed by #481
Labels
help wanted Extra attention is needed Type: Docs Improvements or additions to documentation

Comments

@fedekunze
Copy link
Contributor

Just noticed that the miner namespace endpoints have not been included on the documentation.

  • Add missing endpoints on endpoints.md
  • Add link to miner endpoints on namespaces.md

cc: @ramacarlucho @hanchon

@fedekunze fedekunze added Type: Docs Improvements or additions to documentation help wanted Extra attention is needed labels Aug 23, 2021
@hanchon hanchon mentioned this issue Aug 23, 2021
11 tasks
@hanchon
Copy link
Contributor

hanchon commented Aug 23, 2021

@fedekunze we added a fix when reading the configuration file, because the function that the RPC calls were using was ParseConfig that was returning the node's default configuration instead of the current configuration.

This change makes the 2 miner rpc call work fine, because the setEtherbase function could not read the default min gas because the default MinGasPrice was set to "" (it is using the cosmos-sdk default values). And the SetGasPrice function was saving the new value OK to disk but was overwriting the configuration manually set by the user.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed Type: Docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants