build(v4): fix build on v4 (patternfly#3915)

* fix hoist-non-react-statics types

* also verify @patternfly package versions

* run verify script with --fix

* fix hoist-non-react-statics declaration

* fix linting errors

* fix drawer panel style

* update snapshots

Author: redallen

scripts/verifyPatternflyVersions.js

@@ -25,7 +25,7 @@ function setDependency(dependencies, package, version) {
 }
 
 async function verifyPatternflyVersions() {
-  const packages = await new Project(__dirname).getPackages();
+  const packages = (await new Project(__dirname).getPackages());
 
   packages.forEach(package => {
     accumulateDependencies(package.name, { [package.name]: `^${package.version}` });
@@ -34,21 +34,18 @@ async function verifyPatternflyVersions() {
   });
 
   let failed = false;
-  const mismatchedVersions = Object.entries(patternflyDeps).filter(
-    ([_dep, versions]) => Object.keys(versions).length > 1
-  );
-
+  const mismatchedVersions = Object.entries(patternflyDeps)
+    .filter(([_dep, versions]) => Object.keys(versions).length > 1);
+  
   mismatchedVersions.forEach(([dep, versions]) => {
-    failed = true;
-    console.error(`Mismatching versions for ${dep}:`);
-    Object.entries(versions).forEach(([version, packages]) => console.error(`${version}: ${packages.join(' ')}`));
-  });
-
+      failed = true;
+      console.error(`Mismatching versions for ${dep}:`);
+      Object.entries(versions).forEach(([version, packages]) => console.error(`${version}: ${packages.join(' ')}`));
+    });
+  
   if (process.argv[2] === '--fix') {
     mismatchedVersions.forEach(([dep, versions]) => {
-      const highestVersion = Object.keys(versions)
-        .sort()
-        .reverse()[0];
+      const highestVersion = Object.keys(versions).sort().reverse()[0];
       Object.keys(versions)
         .filter(version => version !== highestVersion)
         .map(version => versions[version])

yarn.lock

@@ -3380,6 +3380,7 @@
 <<<<<<< HEAD
 <<<<<<< HEAD
 <<<<<<< HEAD
+<<<<<<< HEAD
 "@patternfly/patternfly@4.0.4":
   version "4.0.4"
   resolved "https://registry.yarnpkg.com/@patternfly/patternfly/-/patternfly-4.0.4.tgz#b4ba2db3d958c15a610e694a96d975e57e5a1db6"
@@ -3396,127 +3397,26 @@
   integrity sha512-ZsANYyp/AVRaSWAFBnKuoyvVoA1tMT7hh1jHpua0sQYjN4ocuN89MNcNdAJhdawt1Bh+p9OEtDgl4vfKQbJ9RQ==
 >>>>>>> feat(FileUpload) Add new beta File Upload component (#3865)
 =======
+=======
+>>>>>>> build(v4): fix build on v4 (#3915)
 "@patternfly/patternfly@2.70.1":
   version "2.70.1"
   resolved "https://registry.yarnpkg.com/@patternfly/patternfly/-/patternfly-2.70.1.tgz#ef5f9b7912313b873d128002152106c1a5f86b42"
   integrity sha512-vimiUQRX0SdaxFKOWaFQ9Gcva/cnEWl4R9SNx1837TRBonLTyTKmzuDRuaDF09ximiRQyWB08/WLESJLLrEF+A==
 >>>>>>> chore(repo): bump core to 2.70.1 (#3964)
 
+=======
+>>>>>>> build(v4): fix build on v4 (#3915)
 "@patternfly/patternfly@4.0.4":
   version "4.0.4"
   resolved "https://registry.yarnpkg.com/@patternfly/patternfly/-/patternfly-4.0.4.tgz#b4ba2db3d958c15a610e694a96d975e57e5a1db6"
   integrity sha512-ABfuvG0y0Z12Jtd8bxsfjWc9yt9jtQyWonuC0AKRktvn9bFULr7vWJ3Lg+PIXP5WUefPD7D+vGTz8SxdbWgLDA==
 
-"@patternfly/react-catalog-view-extension@^1.4.21":
-  version "1.4.21"
-  resolved "https://registry.yarnpkg.com/@patternfly/react-catalog-view-extension/-/react-catalog-view-extension-1.4.21.tgz#068a89c4c7d257799c8d589f0a608d106975c749"
-  integrity sha512-KewwyApsxDmzKol+mQDYVLUwhKZ2VENR2BIUW1cHmdLF/YgLl9l5XpJREAqxgdqhPubRjH6HivSrwUr8VOzX8w==
-  dependencies:
-    "@patternfly/patternfly" "2.65.3"
-    "@patternfly/react-core" "^3.142.2"
-    "@patternfly/react-styles" "^3.7.6"
-    classnames "^2.2.5"
-    patternfly "^3.59.4"
-
-"@patternfly/react-core@^3.142.2":
-  version "3.142.2"
-  resolved "https://registry.yarnpkg.com/@patternfly/react-core/-/react-core-3.142.2.tgz#aaab6f9b13c3b0e87380600ec213be5ad226b6a7"
-  integrity sha512-+Tnc8mfFz+H+zioYB1SmdLvlPmvnVQX51w6RKP10AEvDgddML8i9g04QkkNb/AwwnIuGcF95b7YgzQc00cfNrA==
-  dependencies:
-    "@patternfly/react-icons" "^3.15.5"
-    "@patternfly/react-styles" "^3.7.6"
-    "@patternfly/react-tokens" "^2.8.6"
-    emotion "^9.2.9"
-    exenv "^1.2.2"
-    focus-trap-react "^4.0.1"
-    tippy.js "5.1.2"
-
-"@patternfly/react-inline-edit-extension@^2.17.21":
-  version "2.17.21"
-  resolved "https://registry.yarnpkg.com/@patternfly/react-inline-edit-extension/-/react-inline-edit-extension-2.17.21.tgz#194f52d6bbcadd0cadd64cc6561be28a99dd01fc"
-  integrity sha512-xm3wf0nwW5KEZKMb4HNfTjYsC8dSGQKGkOP4sXF9+2acLpj13I4V1BBj0nzUMvvnPE8xDeDzYh0oB42whfpeXw==
-  dependencies:
-    "@patternfly/patternfly" "2.65.3"
-    "@patternfly/react-core" "^3.142.2"
-    "@patternfly/react-icons" "^3.15.5"
-    "@patternfly/react-styles" "^3.7.6"
-    "@patternfly/react-table" "^2.28.2"
-    classnames "^2.2.5"
-    exenv "^1.2.2"
-    reactabular-table "^8.14.0"
-  optionalDependencies:
-    "@patternfly/react-tokens" "^2.8.6"
-
-"@patternfly/react-styled-system@^3.8.8":
-  version "3.8.8"
-  resolved "https://registry.yarnpkg.com/@patternfly/react-styled-system/-/react-styled-system-3.8.8.tgz#85ce43ffa5c49832576dd66fa4f51c0c30ecfe81"
-  integrity sha512-syZIHNmjJ7OaDTPP5CYrTB2AV52VY0AQAnbJZVtKpV1ySQXbju/eNAFhmcq41FhCcDAHsvsk5zs8wVAPAMNDeQ==
-  dependencies:
-    "@patternfly/react-styles" "^3.7.6"
-    "@patternfly/react-tokens" "^2.8.6"
-    emotion-theming "^9.2.9"
-    react-emotion "^9.2.9"
-    styled-system "^3.1.11"
-  optionalDependencies:
-    "@types/styled-system" "^3.0.7"
-
-"@patternfly/react-styles@^3.7.6":
-  version "3.7.6"
-  resolved "https://registry.yarnpkg.com/@patternfly/react-styles/-/react-styles-3.7.6.tgz#86b151688089ff049ab42a60eba71de50731686b"
-  integrity sha512-ISwqNcpq6WI82trer/fJxRdDnxYjDsGds6SV4TBv/Z919zQSQAIomw6UAO/fFMsmkTzSriGYQz3pZaLtVNtpJw==
-  dependencies:
-    camel-case "^3.0.0"
-    css "^2.2.3"
-    cssstyle "^0.3.1"
-    emotion "^9.2.9"
-    emotion-server "^9.2.9"
-
-"@patternfly/react-table@^2.28.2":
-  version "2.28.2"
-  resolved "https://registry.yarnpkg.com/@patternfly/react-table/-/react-table-2.28.2.tgz#82cafa099b6e6439ab08fcb16db216eb1ac1570f"
-  integrity sha512-axCwXooClL1ZKFQYO3vDtblOrWpnZ2LksusXjFrTSsLh89AZDXxehqD+PFCtetEbeqODl9wklwKi+mUTLH5v+w==
-  dependencies:
-    "@patternfly/patternfly" "2.65.3"
-    "@patternfly/react-core" "^3.142.2"
-    "@patternfly/react-icons" "^3.15.5"
-    "@patternfly/react-styles" "^3.7.6"
-    "@patternfly/react-tokens" "^2.8.6"
-    classnames "^2.2.5"
-    exenv "^1.2.2"
-    lodash "^4.17.15"
-
 "@patternfly/react-tokens@^2.8.6":
   version "2.8.6"
   resolved "https://registry.yarnpkg.com/@patternfly/react-tokens/-/react-tokens-2.8.6.tgz#dbdf91e354814d2efc3e7409d6161cc7eb926e8c"
   integrity sha512-3GtE1o0NF4V2by4VK2mgpF1jWQCkbWzA5WyOSkhcCYUDerLhlarfuRWJrUOugM6ZmIDEOtrqRuXyXgfEjJFIqQ==
 
-"@patternfly/react-topology@^2.14.21":
-  version "2.14.21"
-  resolved "https://registry.yarnpkg.com/@patternfly/react-topology/-/react-topology-2.14.21.tgz#f1f568bebef3769a595f933c41e0aafa8aaf4cc9"
-  integrity sha512-QmEgLtdZeeSm4/rogUm+YslCr947vOl27TqvNjdy857zcPTDpzpBkMsa4o0MGI7KIZOzfDYKwKTVOUDt3Wsbhw==
-  dependencies:
-    "@patternfly/patternfly" "2.65.3"
-    "@patternfly/react-core" "^3.142.2"
-    "@patternfly/react-icons" "^3.15.5"
-    "@patternfly/react-styles" "^3.7.6"
-
-"@patternfly/react-virtualized-extension@^1.4.22":
-  version "1.4.22"
-  resolved "https://registry.yarnpkg.com/@patternfly/react-virtualized-extension/-/react-virtualized-extension-1.4.22.tgz#7f32123f934fd6f51cf5a77ca89054f7e67d05ec"
-  integrity sha512-cBSmxRnEgq9VPAIqDr7AZkzLfhtBKNsz7GE6MMyeRier7w5UbC7EvXnKMQhOxAL1ZvF9eH/NmU204uuzF3vqdA==
-  dependencies:
-    "@patternfly/patternfly" "2.65.3"
-    "@patternfly/react-core" "^3.142.2"
-    "@patternfly/react-icons" "^3.15.5"
-    "@patternfly/react-styles" "^3.7.6"
-    "@types/react-virtualized" "^9.21.5"
-    clsx "^1.0.1"
-    dom-helpers "^2.4.0 || ^3.0.0"
-    exenv "^1.2.2"
-    linear-layout-vector "0.0.1"
-    react-lifecycles-compat "^3.0.4"
-    react-virtualized "^9.21.1"
-
 "@pieh/friendly-errors-webpack-plugin@1.7.0-chalk-2":
   version "1.7.0-chalk-2"
   resolved "https://registry.yarnpkg.com/@pieh/friendly-errors-webpack-plugin/-/friendly-errors-webpack-plugin-1.7.0-chalk-2.tgz#2e9da9d3ade9d18d013333eb408c457d04eabac0"