Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userChrome.js (autoconfig) Support #44

Open
black7375 opened this issue Jul 14, 2021 · 4 comments
Open

userChrome.js (autoconfig) Support #44

black7375 opened this issue Jul 14, 2021 · 4 comments
Labels
manifest Involves modification of the Manifest struct
Milestone

Comments

@ewen-lbh ewen-lbh modified the milestones: 1.0.0, 1.1.0 Jul 14, 2021
@ewen-lbh
Copy link
Owner

ewen-lbh commented Jul 14, 2021

Note: the milestone might change if this turns out to be easier than expected :)

Your project looks really good!!

Thanks a bunch!

@ewen-lbh ewen-lbh added the manifest Involves modification of the Manifest struct label Jul 22, 2021
@black7375
Copy link
Contributor Author

I hope this code will also help you.
https://github.com/Izheil/Quantum-Nox-Firefox-Dark-Full-Theme/tree/master/Installers/Multirow%20%26%20other%20functions

@ewen-lbh
Copy link
Owner

ewen-lbh commented Jul 23, 2021

@black7375 I just implemented pre & post-install hooks (i.e. the ability to run custom commands/scripts after and/or before theme installation)!

See #40, the Unreleased section of the changelog and d7d8821 for the implementation details, if you're curious.

While this is far from a clean solution to the whole autoconfig support issue, it means that your theme might be able to work on ffcss v0.2.0 and up!

@black7375
Copy link
Contributor Author

LGTM. I really like this project.
I'm sure it will be helpful to many creators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manifest Involves modification of the Manifest struct
Projects
None yet
Development

No branches or pull requests

2 participants