Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stopped batching requests since upgrading to GraphqQL version 1.8.7 #26

Closed
DamirSvrtan opened this issue Oct 13, 2018 · 1 comment
Closed

Stopped batching requests since upgrading to GraphqQL version 1.8.7 #26

DamirSvrtan opened this issue Oct 13, 2018 · 1 comment

Comments

@DamirSvrtan
Copy link

We were on GraphQL 1.8.5 and wanted to upgrade to GraphQL version 1.8.7, but the batch loader stopped batching requests. This is due to the introduction of the scope option in GraphQL 1.8.7 https://github.com/rmosolgo/graphql-ruby/compare/357fb18..5e387ea#diff-4df5462c469f7f83e661688be477a19bR15

I am opening this issue in the hope to get this fixed and in the meantime to show how to fix this if scoping is not needed. It is described in: rmosolgo/graphql-ruby#1778 (comment)
@exAspArk
Copy link
Owner

exAspArk commented Nov 30, 2018 •
edited
Loading

It looks like it works with the latest 1.8.11 version now #22 (comment) and #28

@axelson axelson mentioned this issue Jan 29, 2019
Closed
@exAspArk exAspArk mentioned this issue Jan 31, 2019
Merged
@exAspArk exAspArk mentioned this issue Apr 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@exAspArk @DamirSvrtan